diff options
| author | Bret Curtis <psi29a@gmail.com> | 2020-12-02 23:12:40 +0100 |
|---|---|---|
| committer | Bret Curtis <psi29a@gmail.com> | 2020-12-02 23:12:40 +0100 |
| commit | 1964951f9e079eafade4dd2214ffa379c08978e4 (patch) | |
| tree | 2d60eecd23fb38ec6fb046b027cbd451020d6342 | |
| parent | 926eb0dcb07437b1ca7e621193e6a752358ccfd4 (diff) | |
documented that currently underwater shadows are mutually exclusive to refraction scale; to be fixed in follow up issue #5709; documentation fixesbzzt_8_shadows_in_refraction
| -rw-r--r-- | apps/openmw/mwrender/water.cpp | 4 | ||||
| -rw-r--r-- | docs/source/reference/modding/settings/water.rst | 5 |
2 files changed, 6 insertions, 3 deletions
diff --git a/apps/openmw/mwrender/water.cpp b/apps/openmw/mwrender/water.cpp index eee52f5992..b9018e0a27 100644 --- a/apps/openmw/mwrender/water.cpp +++ b/apps/openmw/mwrender/water.cpp @@ -242,7 +242,7 @@ public: setSmallFeatureCullingPixelSize(Settings::Manager::getInt("small feature culling pixel size", "Water")); setName("RefractionCamera"); setCullCallback(new InheritViewPointCallback); - setComputeNearFarMode(osg::CullSettings::DO_NOT_COMPUTE_NEAR_FAR); // for shadows bugfix + setComputeNearFarMode(osg::CullSettings::DO_NOT_COMPUTE_NEAR_FAR); setCullMask(Mask_Effect|Mask_Scene|Mask_Object|Mask_Static|Mask_Terrain|Mask_Actor|Mask_ParticleSystem|Mask_Sky|Mask_Sun|Mask_Player|Mask_Lighting); setNodeMask(Mask_RenderToTexture); @@ -285,7 +285,7 @@ public: attach(osg::Camera::DEPTH_BUFFER, mRefractionDepthTexture); - if (Settings::Manager::getFloat("refraction scale", "Water") != 1) + if (Settings::Manager::getFloat("refraction scale", "Water") != 1) // TODO: to be removed with issue #5709 SceneUtil::ShadowManager::disableShadowsForStateSet(getOrCreateStateSet()); } diff --git a/docs/source/reference/modding/settings/water.rst b/docs/source/reference/modding/settings/water.rst index 3581efb991..b79daacb7d 100644 --- a/docs/source/reference/modding/settings/water.rst +++ b/docs/source/reference/modding/settings/water.rst @@ -59,7 +59,7 @@ This setting has no effect if the shader setting is false. This setting can be toggled with the 'Refraction' button in the Water tab of the Video panel of the Options menu. reflection detail --------------- +----------------- :Type: integer :Range: 0, 1, 2, 3, 4 @@ -111,3 +111,6 @@ This setting only applies if water shader is on and refractions are enabled. Not setting if off, there will still be small refractions caused by the water waves, which however do not cause such significant distortion. +.. warning:: + The `refraction scale` is currently mutually exclusive to underwater shadows. Setting this to any value except 1.0 + will cause underwater shadows to be disabled. This will be addressed in issue https://gitlab.com/OpenMW/openmw/-/issues/5709 |