diff options
| author | Kenny Levinsen <kl@kl.wtf> | 2022-01-11 11:08:44 +0100 |
|---|---|---|
| committer | Simon Ser <contact@emersion.fr> | 2022-01-16 19:26:57 +0100 |
| commit | 67d3d952b6cd328ffd053ad4f52dc1687e28a56b (patch) | |
| tree | f1d8214fbd5d5a239f135cd6726a3d28f1f15996 | |
| parent | 02a69dde9f1f3a7bd1435effabf5fef9f78d8649 (diff) | |
Print deprecation notice when running SUID
SUID privilege drop is needed for the "builtin"-backend of libseat,
which copied our old "direct" backend behavior for the sake of
compatibility and ease of transition.
libseat now has a better alternative in the form of seatd-launch. It
uses the normal seatd daemon and libseat backend and takes care of SUID
for us.
Add a soft deprecation warning to highlight our future intent of
removing this code. The deprecation cycle is needed to avoid surprises
when sway no longer drops privileges.
(cherry picked from commit e1db1f8218998c428e8b087dda6660449ef2891a)
| -rw-r--r-- | sway/main.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/sway/main.c b/sway/main.c index 6c71048b0..b6f8a8bf4 100644 --- a/sway/main.c +++ b/sway/main.c @@ -153,6 +153,9 @@ static void log_kernel(void) { static bool drop_permissions(void) { if (getuid() != geteuid() || getgid() != getegid()) { + sway_log(SWAY_ERROR, "!!! DEPRECATION WARNING: " + "SUID privilege drop will be removed in a future release, please migrate to seatd-launch"); + // Set the gid and uid in the correct order. if (setgid(getgid()) != 0) { sway_log(SWAY_ERROR, "Unable to drop root group, refusing to start"); |