diff options
author | Dreamy Jazz <dreamyjazzwikipedia@gmail.com> | 2023-08-23 14:52:50 +0100 |
---|---|---|
committer | Gerrit Code Review <gerrit@wikimedia.org> | 2023-08-23 13:52:50 +0000 |
commit | bdd6e84194193292e2da59dc730e5c7426833548 (patch) | |
tree | e0be377b8bb6e157f6f21f815e7c3d931b52a25c | |
parent | 2bd8a9ddf6820b2e80c9402c8a7612a1e5a3e9c2 (diff) |
Update git submoduleswmf/1.41.0-wmf.22
* Update extensions/CheckUser from branch 'wmf/1.41.0-wmf.22'
to 78852f30c0cb0e89403e7a86a119e1b8bd7c894f
- clienthints: Remove duplicate entries when converting to DB rows
When converting a ClientHintsData object to the equivalent database
rows, remove duplicate entries by using array_unique on the uach_value
column for names that accept an array (e.g. brands or fullVersionList).
This is done by converting all the items in the array to the string
form and then calling array_unique on the items in ClientHintsData
::toDatabaseRows. This ensures that the rows do not contain any
duplicates, as the cu_useragent_clienthints table does not support
including duplicate entries.
This fixes the issue with the insert to cu_useragent_clienthints_map
as the insert query will be generated with unique Client Hints data
rows. This is done instead of de-duplication in UserAgentClientHints
Manager::insertMappingRows as other methods would not be wrong in
assuming that the rows returned from ClientHintsData::toDatabaseRows
would be fine to insert to the DB as is.
A checkuser running a check is very likely to not find use in knowing
that duplicate entries were submitted, so de-duplication at the time
of insert is fine. To support storing that a item was duplicated,
a database schema change would be needed.
Bug: T344787
Change-Id: If6c5408f27ca22c8d228a1e61a5f2f50f5a985a1
(cherry picked from commit 92729522b4fdd2dbaee9823deeac3ffe94a80393)
m--------- | extensions/CheckUser | 0 |
1 files changed, 0 insertions, 0 deletions
diff --git a/extensions/CheckUser b/extensions/CheckUser -Subproject 084c04e84486d845215e83c63f4688841680e96 +Subproject 78852f30c0cb0e89403e7a86a119e1b8bd7c894 |