diff options
author | Urbanecm <martin.urbanec@wikimedia.cz> | 2023-05-31 14:06:36 +0000 |
---|---|---|
committer | Gerrit Code Review <gerrit@wikimedia.org> | 2023-05-31 14:06:36 +0000 |
commit | 2defe3dc6ac645aaefb6a0bd80b8263a60895616 (patch) | |
tree | 458c06c0e7e963d13f4eb96e1b329b278a32cb98 | |
parent | 93c1d0a63a4e49e0edad3c9cc42f84159fd3442b (diff) |
Update git submoduleswmf/1.41.0-wmf.10
* Update extensions/GrowthExperiments from branch 'wmf/1.41.0-wmf.10'
to 0fff8b72f41dacd696e4b31ac5135c708312a5d8
- Merge "NewImpact: Cache empty user impact on account creation" into wmf/1.41.0-wmf.10
- NewImpact: Cache empty user impact on account creation
Why:
- When the Vue app has no server-side data about user impact, it makes a
HTTP request to the user impact API endpoint. That means: new users
with zero edits wait for the Vue application to load, then wait for it
to make a HTTP request, only to then see an empty application state.
What:
- Cache an empty user impact object in the NewImpact module during the
account creation process.
Alternatives:
- Rework App.vue to create an empty impact data object if the user has
no edit data. Would require crafting an empty object and
keeping it sync with the user impact data structure.
- Rework NewImpact.php to load an empty user impact object if
UserImpact->getExpensiveUserImpact returns null. This is somewhat
awkward, though.
Bug: T337320
Change-Id: Ib201e280d21b411affa623c5f5c5a7d361b75dd8
(cherry picked from commit d58213cc6fba9c7a641a29fab7b21d6ba0d38941)
- Personalized praise: Fix first-ever notifications
Due to an incorrect condition,
PersonalizedPraiseNotificationsDispatcher refused
to send the very first batched notification. The intended
logic is to send a notification to users who either:
* never were notified ($rawLastNotifiedTS is null), or
* were notified too long ago ($notifiedSecondsAgo is greater
than the threshold).
Bug: T322452
Change-Id: Ib63d72b028009a0681e9aa05d6577ead634d4714
(cherry picked from commit 2f526705aa10c8181c881adcc0f00e78112a7ced)
m--------- | extensions/GrowthExperiments | 0 |
1 files changed, 0 insertions, 0 deletions
diff --git a/extensions/GrowthExperiments b/extensions/GrowthExperiments -Subproject 2263a52affe9a97f04b011ad2cef36862e8df3c +Subproject 0fff8b72f41dacd696e4b31ac5135c708312a5d |