summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorfaried nawaz <faried@gmail.com>2023-05-18 03:20:44 +0500
committerfaried nawaz <faried@gmail.com>2023-05-29 02:52:49 +0500
commit8b390d27dce0c1827ed4c8c959612b6126624c9a (patch)
tree31309a9fc3073b3e1e4222385c3307488e7fa58a
parenta1af122499d3558d9fa6d5606c394e01f36e95e4 (diff)
twitter card: handle case where image has no alt text
-rw-r--r--lib/pleroma/web/metadata/providers/twitter_card.ex5
1 files changed, 3 insertions, 2 deletions
diff --git a/lib/pleroma/web/metadata/providers/twitter_card.ex b/lib/pleroma/web/metadata/providers/twitter_card.ex
index fbd4fd5a7..426022c65 100644
--- a/lib/pleroma/web/metadata/providers/twitter_card.ex
+++ b/lib/pleroma/web/metadata/providers/twitter_card.ex
@@ -79,8 +79,7 @@ defmodule Pleroma.Web.Metadata.Providers.TwitterCard do
name: "twitter:image",
content: MediaProxy.url(url["href"])
], []},
- {:meta, [property: "twitter:image:alt", content: truncate(attachment["name"])],
- []}
+ {:meta, [name: "twitter:image:alt", content: truncate(attachment["name"])], []}
| acc
]
|> maybe_add_dimensions(url)
@@ -133,6 +132,8 @@ defmodule Pleroma.Web.Metadata.Providers.TwitterCard do
end
end
+ defp truncate(nil), do: ""
+
defp truncate(text) do
# truncate to 420 characters
# see https://developer.twitter.com/en/docs/twitter-for-websites/cards/overview/markup