From 28dc22a0ff77b5d961c11efddc50ff2b8cd663e2 Mon Sep 17 00:00:00 2001 From: sourque Date: Sat, 27 Nov 2021 01:17:17 -0800 Subject: Check for empty feed title For feeds with no title, openring places a link with no clickable text on the byline ("via ..."). Instead, we replace the empty title with a sensible substitute (URL.Host). Additionally, fix an unhandled error. --- openring.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/openring.go b/openring.go index e1865b8..aa74469 100644 --- a/openring.go +++ b/openring.go @@ -107,6 +107,10 @@ func main() { log.Printf("Error fetching %s: %s", source.String(), err.Error()) continue } + if feed.Title == "" { + log.Printf("Warning: feed from %s has no title", source.Host) + feed.Title = source.Host + } feeds = append(feeds, feed) log.Printf("Fetched %s", feed.Title) } @@ -142,7 +146,7 @@ func main() { summary := runewidth.Truncate( policy.Sanitize(raw_summary), *summaryLen, "…") - itemLink, _ := url.Parse(item.Link) + itemLink, err := url.Parse(item.Link) if err != nil { log.Fatal("failed parsing article URL of the feed item") } -- cgit v1.2.3