summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorcody glassman <glassmancody.info@gmail.com>2022-01-08 16:12:24 -0800
committercody glassman <glassmancody.info@gmail.com>2022-01-08 16:12:24 -0800
commite32d3d11ce53e97c27a02047632a99f30bf1a470 (patch)
treee536d55c6c4b1b1378d05c7056539be085198c91
parent99e4cbf51397b749f73b748418616aea48da09ef (diff)
ensure readbuffer is bound before using glReadPixels
-rw-r--r--apps/openmw/mwrender/screenshotmanager.cpp9
1 files changed, 6 insertions, 3 deletions
diff --git a/apps/openmw/mwrender/screenshotmanager.cpp b/apps/openmw/mwrender/screenshotmanager.cpp
index 1973ca4025..5c3d925c9b 100644
--- a/apps/openmw/mwrender/screenshotmanager.cpp
+++ b/apps/openmw/mwrender/screenshotmanager.cpp
@@ -91,15 +91,18 @@ namespace MWRender
int width = screenW - leftPadding*2;
int height = screenH - topPadding*2;
- // Ensure we are reading from the resolved framebuffer and not the multisampled render buffer when in use.
- // glReadPixel() cannot read from multisampled targets.
+ // Ensure we are reading from the resolved framebuffer and not the multisampled render buffer. Also ensure that the readbuffer is set correctly with rendeirng to FBO.
+ // glReadPixel() cannot read from multisampled targets
PostProcessor* postProcessor = dynamic_cast<PostProcessor*>(renderInfo.getCurrentCamera()->getUserData());
- if (postProcessor && postProcessor->getFbo() && postProcessor->getMsaaFbo())
+ if (postProcessor && postProcessor->getFbo())
{
osg::GLExtensions* ext = osg::GLExtensions::Get(renderInfo.getContextID(), false);
if (ext)
+ {
ext->glBindFramebuffer(GL_FRAMEBUFFER_EXT, postProcessor->getFbo()->getHandle(renderInfo.getContextID()));
+ renderInfo.getState()->glReadBuffer(GL_COLOR_ATTACHMENT0_EXT);
+ }
}
mImage->readPixels(leftPadding, topPadding, width, height, GL_RGB, GL_UNSIGNED_BYTE);