summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-01-19Update git submoduleswmf/1.38.0-wmf.17Cparle
* Update extensions/MediaSearch from branch 'wmf/1.38.0-wmf.17' to 2aa57de30aa2b6642a44ef2eafe518a8272ea210 - Revert "Undo update to the way the search interface is set" This reverts commit 4b1e241101b02eb58e9b3da3ad6dd443e019d298. Reason for revert: reverting to re-enable functionality changes that had been removed pending a maint script Change-Id: Iab21fb6702cdd0953fc95500197aeae7319a0a35
2022-01-19Update git submodulesBartosz Dziewoński
* Update extensions/DiscussionTools from branch 'wmf/1.38.0-wmf.17' to 64e70604fd2a0d9bfe830f2f51d27e365f180151 - Ensure the marker appears in a reasonable place when replying with a bullet Bug: T259864 Change-Id: I782460797ea78ab689cbab19c631f651315d2c8f (cherry picked from commit faf6da62cc5edf2b2ec12b6b3da289d1ef08ea1a)
2022-01-19Update git submodulesBartosz Dziewoński
* Update extensions/DiscussionTools from branch 'wmf/1.38.0-wmf.17' to 615c12cdbae3472aff86aab2351b4092b7fcc9e8 - Enable wikis to customize the syntax used for replies The following values for configuration variables are supported: $wgDiscussionToolsReplyIndentation = 'invisible'; (default) $wgDiscussionToolsReplyIndentation = 'bullet'; Bug: T259864 Change-Id: Icefad79630adc6ed35687498614e6a03ede1451b (cherry picked from commit 7b1053300a8b4f3230ef0b78bbc0970472ab5c31)
2022-01-18Update git submodulesjenkins-bot
* Update extensions/GrowthExperiments from branch 'wmf/1.38.0-wmf.17' to 9de43da4b3ba446749e9e52a750c23792497c63b - Merge "Monitoring: Add '.Save' to distinguish from '.Click' events" into wmf/1.38.0-wmf.17 - Monitoring: Add '.Save' to distinguish from '.Click' events Bug: T286366 Change-Id: Icecd0463473446615132f5874e9ffcf79d0d08c4
2022-01-18Update git submodulesMewOphaswongse
* Update extensions/GrowthExperiments from branch 'wmf/1.38.0-wmf.17' to f1c9b9b476ee4d5aae7a7ad4b20b14a6a23034af - Post-edit dialog: Reload page upon dialog closing for structured tasks Bug: T299188 Change-Id: Ic1545ef854b20dc862f7a767853f52aec47ecff0
2022-01-18Update git submodulesjenkins-bot
* Update extensions/Linter from branch 'wmf/1.38.0-wmf.17' to cc32271e7152bf76df1efce43206cd87904daf43 - Merge "Disable "inline-media-caption" category" into wmf/1.38.0-wmf.17 - Disable "inline-media-caption" category Note that this only removes the category from the special page and the lints will still show up by page. Those need purging separately or more code to filter out disabled categories from the results. Bug: T297443 Change-Id: Idfcf5ee5d69f5dc65100229aacb22137be475866 (cherry picked from commit 6898415d8dd79d93753ec3385213d24ee05e3495)
2022-01-18page: Use MainObjectStash instead of 'db-replicated' cacheAmir Sarabadani
This is for page-recent-delete and db-replicated should not be used for this. Simply use the standard and common service providing the same functionality. Bug: T272512 Change-Id: Iabaffd726370f5a580097819fd854da82bf43907 (cherry picked from commit 5954d3edffe8ffcd56dc2873e63d41dcb96589ac)
2022-01-18watcheditem: Try getting the cached version in resetNotificationTimestampAmir Sarabadani
loadWatchedItem() bypasses cache and because of that, now we have a duplicate query to watchlist table in EVERY PAGE VIEW. You can follow the code path in https://performance.wikimedia.org/xhgui/run/symbol?id=61d70085b6eef2185e6c1353&symbol=WatchedItemStore%3A%3AloadWatchedItem Change-Id: I534a46bdc956bbefe1c5c9d2db82eabec3cbd5e6 (cherry picked from commit a3250bd942b9faa1145805f7867bee36cf85aceb)
2022-01-18Update git submodulesAmir Sarabadani
* Update extensions/ProofreadPage from branch 'wmf/1.38.0-wmf.17' to ec596aba921c01e52f2e699e7b1a6114c6d408f2 - Use fillParserOutputInternal instead of getParserOutput. The latter is keeping track of duplicate parses and triggering a lot of duplicate parses errors now. Bug: T292300 Change-Id: Ib26befd08c197e0a4d51fee4d94b330c78049723 (cherry picked from commit 536aff451650924c9128a2ba5eb26b4536b20376)
2022-01-18Update git submodulesSubramanya Sastry
* Update extensions/Linter from branch 'wmf/1.38.0-wmf.17' to 9b5dfb907ad0e934d7401a6a2123c77375a51b95 - Drop 'inline-media-caption' lint requests Bug: T297443 Bug: T299302 Change-Id: Id158f1fef8be06ddac733c71b7c1e26a58270955
2022-01-14Revert "LinksUpdate refactor" and follow-upsKunal Mehta
This reverts commit 682aad7557ebb09c2aefa84d2c0c1f6c87ea5b76. This reverts commit 87d8ccbd3e5280582a1bd60771b821ee5bbc95a7. This reverts commit 1aecb692f64b3166cbaf1a7de9d85790ebc8759f. This reverts commit d3b2b800678e91fd1a6177d80fde790c9006d423. Bug: T299244 Change-Id: I9f17df9ad49c1cf75fcf36e1c1e7d72cf50caf15
2022-01-13In WikitextContentHandler always use getFreshParser()Tim Starling
Make it safe to parse articles while in the parser, by always calling getFreshParser() from WikitextContentHandler. I think ideally this should be a ParserFactory responsibility, with Parser instances stored by ParserFactory instead of directly by ServiceContainer, but this fixes the bug, follows existing conventions, and does not reduce performance in the usual case. Bug: T299149 Change-Id: Ibbc1423166f4804a5122de10293ea26f5704d96d
2022-01-13Update git submodulesAmir Sarabadani
* Update extensions/SpamBlacklist from branch 'wmf/1.38.0-wmf.17' to 3004fb25852345517c45718efeac02c4fbb625eb - Take LogicException into consideration It can be caused by undo Bug: T299111 Change-Id: I94054648ddfe95b59668ad3f53ac864e0c5f6e30
2022-01-12Database::factorConds(): fix insufficient parenthesizationTim Starling
Bug: T299095 Change-Id: I9746e69b7b4f79d0afb9b965da43b9ae36c6afe4
2022-01-12Partial revert of I1a691f01cd82e60bf41207d32501edb4b9835e37 to unbreak dumpsAriel T. Glenn
Bug: T299020 Change-Id: I32fc4b0240efb2845bf064d07942fdbc9fe94342 (cherry picked from commit ca741848dfc65027536bd43ed362aeb9cc3c90e9)
2022-01-12Update git submodulesjenkins-bot
* Update extensions/MediaSearch from branch 'wmf/1.38.0-wmf.17' to 49a1b7827fe0a73d679aa176ce4d386856b93000 - Merge "Undo update to the way the search interface is set" into wmf/1.38.0-wmf.17 - Undo update to the way the search interface is set We only intend to deploy this if we fail to successfully run the maintenance script in time, converting all existing preferences to their new equivalent. If that doesn't happen, we need to merge this to undo the changes, since people would otherwise find their preferences no longer respected. Change-Id: I5f674084cfa0bd45ca60225d48a42805437cd136
2022-01-12Update git submodulesThiemo Kreuz
* Update extensions/TemplateData from branch 'wmf/1.38.0-wmf.17' to dccfd7096e6d3e2fd83e0b03a1d458039f168710 - Allow aliases to be integers in addition to strings Parameter names in a template can be numeric. While it makes a lot of sense to force a specific format in the TemplateData JSON (i.e. only strings), it's inconvenient and confusing if numbers are rejected for being "invalid". Effects of this patch: * The incoming JSON is allowed to contain numbers in the aliases array. * However, the API normalizes these and forces all aliases to be strings, as it was always documented. * The editor component accepts anything in the aliases array, but forces all aliases to be strings. Again, as documented. * Note that it was never possible to use numeric keys in the `params` list. This patch is only about aliases. At the moment this is a somewhat "hidden" feature. We might or might not update the documentation to officially allow numeric aliases. Bug: T298795 Change-Id: I32ea296b4520e7f21b03a1f6390db4f43b613bdd
2022-01-12Update git submodulesCormac Parle
* Update extensions/MediaSearch from branch 'wmf/1.38.0-wmf.17' to 854f1747a9bf0f5e1bed46a8347c796853a9584a - Updated maint script to use fewer queries Bug: T297484 Change-Id: I87f2a7a855b3ecffeb97a6733ec09ecae7fde757
2022-01-11Update git submodulesEd Sanders
* Update extensions/VisualEditor from branch 'wmf/1.38.0-wmf.17' to 696e089ce30c4c2beb5af77797d6ed916811c10f - Watchlist API update: Call correct method We changed the arguments, but not the function name. Bug: T298999 Change-Id: Ic7b36f666ead57bc62aa6e40e148821ea267ee80 (cherry picked from commit aea22d546e0949b5bd138dd692a4b2042ab0235d)
2022-01-11export: Remove ignoring rev_page_id indexAmir Sarabadani
We are removing this index and that would cause queries that explicitly ignore this index to fail. Bug: T163532 Change-Id: I688c669a89f079e92213f41463b8e2a83c1a54b3 (cherry picked from commit c843af877b68dae7ae3c4f90ce8b057b508576dc)
2022-01-11Update git submodulesGergő Tisza
* Update extensions/GrowthExperiments from branch 'wmf/1.38.0-wmf.17' to c7ae734fb0631b8333fde6351a12995dcd8ca229 - SECURITY: Fix several i18n XSS issues in suggested edits Bug: T298504 Bug: T298019 Change-Id: Iadc224a038ef0cec072cc1d6b84277355648f9f9 (cherry picked from commit bf8c4f8d9fd5c22efaa688aff27a31ec5f672725)
2022-01-11Update git submodulesTim Starling
* Update extensions/PageImages from branch 'wmf/1.38.0-wmf.17' to be9977362eadab8302460a0b15e1cd3f144adcd3 - Strip comments from indicators They are documented as being HTML, so look for candidate comments and strip them, same as we do for the main HTML. Bug: T298930 Change-Id: I7caf96b8d15f887e0be4c9a24acfd981b3e7a776 (cherry picked from commit 372b5938f56d9bef6c5d788e9b079088da477710)
2022-01-11Branch commit for wmf/1.38.0-wmf.17trainbranchbot
Change-Id: I03a644c370ff79e8c6de92a918c3f827d69d7487
2022-01-11Styles should be added to all IndexPagersJon Robson
TablePager extends IndexPager to add styles to the page However, these styles need to be added to the history page too which uses the HistoryPager where extends IndexPager. Follow up to I0cba011f0ab8cb8fd59962b5eafb7650deefe841 Bug: T298636 Change-Id: I9648308b1c1eb1a544f138c1fcf5e7cd155d172f
2022-01-10Merge "ChangesList: Add .mw-changeslist-time (no date) to output to each row"jenkins-bot
2022-01-10ChangesList: Add .mw-changeslist-time (no date) to output to each rowjdlrobson
Bug: T298639 Change-Id: I0cba011f0ab8cb8fd59962b5eafb7650deefe841
2022-01-10Merge "SECURITY: properly escape output used within galleries and ↵jenkins-bot
Special:RevisionDelete"
2022-01-10Merge "Refactor global variables to use MediaWikiServices instead"jenkins-bot
2022-01-10SECURITY: properly escape output used within galleries and ↵sbassett
Special:RevisionDelete * Sanitize $img->getDimensionsString() within TraditionalImageGallery.php * Sanitize width, height, nbytes messages within RevDelFileItem.php Bug: T297543 Change-Id: I586a052595ecdc976476d4330510750a59099648
2022-01-10Merge "MemcachedClient: Add support for ipv6"jenkins-bot
2022-01-10Merge "Move LinksUpdate and LinksDeletionUpdate into the new namespace"jenkins-bot
2022-01-10Merge "Move the link updates from moveUnsafe() to LinksUpdate"jenkins-bot
2022-01-10Refactor global variables to use MediaWikiServices insteadTChin
Automatically refactors wg prefixed globals to use MediaWikiServices config using Rector. Doesn't include files that set globals or files that fail CI. Rector Gist: https://gist.github.com/tchin25/7cc54f6d23aedef010b22e4dfbead228 * This patch uses a modified source code rector library for our specific use case and the rector will have different effects without it. A writeup for future reference is here: https://meta.wikimedia.org/wiki/User:TChin_(WMF)/Using_Rector_On_MediaWiki Change-Id: I1a691f01cd82e60bf41207d32501edb4b9835e37
2022-01-10Merge "Write to multiple categorylinks tables on update"jenkins-bot
2022-01-10Merge "LinksUpdate refactor"jenkins-bot
2022-01-10Merge "Hard deprecate wfGetCache() and wfGetMainCache()"jenkins-bot
2022-01-10Remove unused EditPage::$mPreloadContent propertyThiemo Kreuz
Unused: https://codesearch.wmcloud.org/search/?q=%3E(mPreload%7CsetPreloaded)(Text%7CContent)&files=%5C.php%24 There was a public setter `setPreloadedContent()` that was removed in 2020 in patch Id47421e, tracked via T252907. The fact that the property is marked as public is most certainly not intentional. It was introduced when `private` didn't exist. Not only that. It was dynamically created and never declared. This was fixed in 2011, see https://phabricator.wikimedia.org/rMWaa9bc3ba41273f911bad6a3ac754c98e1dde229a The assumption was made that the property was meant to be public, but I think this was a mistake. Bug: T297725 Change-Id: Ic6a12d706c823c31b8e8a736f078977ec64be973
2022-01-10Localisation updates from https://translatewiki.net.Translation updater bot
Change-Id: I892a7e01d7a87be0fdfba0402ffc573e0b113167
2022-01-10Merge "Add tests for ApiMain::sendCacheHeaders"jenkins-bot
2022-01-10multiselect: Replace overqualified jQuery selectorFunc
HTMLMultiSelectField can be extended, and mw-htmlform-field-* would be changed accordingly. Only in OOUI mode can have multiple elements with mw-htmlform-dropdown class, so it's fine to use `:not(.oo-ui-widget)`. Change-Id: I921eefb1eb3b4b48613a657645f58f7a87c9504c
2022-01-09Hard deprecate wfGetCache() and wfGetMainCache()Alexander Vorwerk
Bug: T293928 Change-Id: I7d9220730cb1f09d5b22f271fb172bd4640212ad
2022-01-09Fix typos in comments (S)Siddharth VP
Change-Id: Id86769ca81ff65707edde520585aa9ea117123e1
2022-01-09Fix typos in comments (N-R)Siddharth VP
Change-Id: I2d1bdb7531ff5126114a391550c2615ea6e244b3
2022-01-09Fix typos in comments (M)Siddharth VP
Change-Id: I5ab88a01ba3e5ea2aae853bb6f06492fbc84ceb5
2022-01-09Fix typos in comments (L)Siddharth VP
Change-Id: I3deb34aec51504e09b20a367a93ebe863335be26
2022-01-09Fix typos in docsSiddharth VP
Change-Id: I5ccf296e0bd9afd8a82b620002346496cef18f0e
2022-01-09Merge "Rename FormSpecialPage::[pre|post]Text() to *Html()"jenkins-bot
2022-01-08Merge "Rename HTMLForm::[get|set|add]*Text() methods"jenkins-bot
2022-01-08Merge "Wrap StatusValue in Status for HTMLForm submit callback"jenkins-bot
2022-01-07Sync up with Parsoid parserTests.txtArlo Breault
This now aligns with Parsoid commit d9cbfe3ae95ead0111e935f214408ccb49aa12a6 Change-Id: Id5dd98d2bd54187a060ae7523de634747e5d7594