diff options
| author | Thiemo Kreuz <thiemo.kreuz@wikimedia.de> | 2022-01-10 09:25:54 +0100 |
|---|---|---|
| committer | Thiemo Kreuz <thiemo.kreuz@wikimedia.de> | 2022-01-10 10:11:54 +0100 |
| commit | 5430e9cf3d63e037955dc026cc2dedc5e913b2c3 (patch) | |
| tree | 8390a67d0cf4f93ba3c7cf3168b6c538e98d2eca | |
| parent | 4b3c8f046af43ed0f21d9aa74154482749e6bbe1 (diff) | |
Remove unused EditPage::$mPreloadContent property
Unused:
https://codesearch.wmcloud.org/search/?q=%3E(mPreload%7CsetPreloaded)(Text%7CContent)&files=%5C.php%24
There was a public setter `setPreloadedContent()` that was removed in
2020 in patch Id47421e, tracked via T252907.
The fact that the property is marked as public is most certainly not
intentional. It was introduced when `private` didn't exist. Not only
that. It was dynamically created and never declared. This was fixed
in 2011, see
https://phabricator.wikimedia.org/rMWaa9bc3ba41273f911bad6a3ac754c98e1dde229a
The assumption was made that the property was meant to be public, but
I think this was a mistake.
Bug: T297725
Change-Id: Ic6a12d706c823c31b8e8a736f078977ec64be973
| -rw-r--r-- | includes/EditPage.php | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/includes/EditPage.php b/includes/EditPage.php index 5c11fdbe1678..8859c51c068b 100644 --- a/includes/EditPage.php +++ b/includes/EditPage.php @@ -345,7 +345,6 @@ class EditPage implements IEditObject { public $editFormTextBottom = ''; public $editFormTextAfterContent = ''; public $previewTextAfterContent = ''; - public $mPreloadContent = null; /* $didSave should be set to true whenever an article was successfully altered. */ public $didSave = false; @@ -1565,10 +1564,6 @@ class EditPage implements IEditObject { * @since 1.21 */ protected function getPreloadedContent( $preload, $params = [] ) { - if ( !empty( $this->mPreloadContent ) ) { - return $this->mPreloadContent; - } - $handler = $this->contentHandlerFactory->getContentHandler( $this->contentModel ); if ( $preload === '' ) { |